fix(NODE-3194): Ignore undefined and null options in MongoClient constructor #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
requested review from
a team,
durran,
emadum and
nbbeeken
and removed request for
a team
dariakp
force-pushed
the
NODE-3194/allow-passing-undefined-opts-to-MongoClient
branch
from
bc134aa
to
55b08b5
Compare
nbbeeken
requested changes
May 6, 2021
Co-authored-by: Neal Beeken <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
…tructor (#2800) Co-authored-by: Neal Beeken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix NODE-3194: MongoClient constructor should not try to parse undefined or null options